Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: conventional lookups using log-deriv #7020

Merged
merged 49 commits into from
Jun 25, 2024
Merged

Conversation

ledwards2225
Copy link
Contributor

@ledwards2225 ledwards2225 commented Jun 11, 2024

Replaces the plookup based lookup argument in UltraHonk/MegaHonk with a log-derivative based argument. This is advantageous in a number of ways including 1) no more committing to expensive z_lookup poly (especially relevant for structured trace), 2) prover work is proportional to number of lookups not size of circuit.'

Below are the benchmark results (master vs branch). Note that most of the benefit is derived from no longer needing to commit to z_lookup which was previously the most expensive single commitment. The Lookup relation also goes from being 45% of total accumulate work, to only 10%.

--------------------------------------------------------------------------------
Benchmark                      Time             CPU   Iterations UserCounters...
--------------------------------------------------------------------------------
ClientIVCBench/Full/6      16151 ms        11247 ms            1 
function                                  ms     % sum
construct_circuits(t)                   3241    20.23%
ProverInstance(Circuit&)(t)             1575     9.83%
ProtogalaxyProver::fold_instances(t)    7627    47.61%
Decider::construct_proof(t)              503     3.14%
ECCVMProver(CircuitBuilder&)(t)          173     1.08%
ECCVMProver::construct_proof(t)         1904    11.88%
TranslatorProver::construct_proof(t)     819     5.11%
Goblin::merge(t)                         177     1.11%

Total time accounted for: 16019ms/16151ms = 99.18%

Major contributors:
function                                  ms    % sum
commit(t)                               4114   25.68%
compute_combiner(t)                     2824   17.63%
compute_perturbator(t)                   795    4.96%
compute_univariate(t)                   1149    7.17%

Breakdown of ProtogalaxyProver::fold_instances:
ProtoGalaxyProver_::preparation_round(t)           3721    48.79%
ProtoGalaxyProver_::perturbator_round(t)            795    10.43%
ProtoGalaxyProver_::combiner_quotient_round(t)     2826    37.05%
ProtoGalaxyProver_::accumulator_update_round(t)     284     3.73%

Relation contributions (times to be interpreted relatively):
function                        ms     % sum
Arithmetic::accumulate(t)     1490     5.78%
Permutation::accumulate(t)    6746    26.18%
Lookup::accumulate(t)        11679    45.33%
DeltaRange::accumulate(t)      977     3.79%
Elliptic::accumulate(t)        635     2.46%
Auxiliary::accumulate(t)      3812    14.79%
EccOp::accumulate(t)             0     0.00%
DatabusRead::accumulate(t)       1     0.01%
PoseidonExt::accumulate(t)     110     0.43%
PoseidonInt::accumulate(t)     316     1.23%
--------------------------------------------------------------------------------
Benchmark                      Time             CPU   Iterations UserCounters...
--------------------------------------------------------------------------------
ClientIVCBench/Full/6      15345 ms        10707 ms            1 
function                                  ms     % sum
construct_circuits(t)                   3183    21.01%
ProverInstance(Circuit&)(t)             1697    11.20%
ProtogalaxyProver::fold_instances(t)    6754    44.57%
Decider::construct_proof(t)              467     3.08%
ECCVMProver(CircuitBuilder&)(t)          176     1.16%
ECCVMProver::construct_proof(t)         1910    12.60%
TranslatorProver::construct_proof(t)     815     5.38%
Goblin::merge(t)                         150     0.99%

Total time accounted for: 15153ms/15345ms = 98.74%

Major contributors:
function                                  ms    % sum
commit(t)                               3379   22.30%
compute_combiner(t)                     2200   14.52%
compute_perturbator(t)                   739    4.87%
compute_univariate(t)                   1118    7.38%

Breakdown of ProtogalaxyProver::fold_instances:
ProtoGalaxyProver_::preparation_round(t)           3529    52.24%
ProtoGalaxyProver_::perturbator_round(t)            739    10.94%
ProtoGalaxyProver_::combiner_quotient_round(t)     2202    32.60%
ProtoGalaxyProver_::accumulator_update_round(t)     285     4.22%

Relation contributions (times to be interpreted relatively):
function                        ms     % sum
Arithmetic::accumulate(t)     1474     9.69%
Permutation::accumulate(t)    6515    42.84%
Lookup::accumulate(t)         1622    10.67%
DeltaRange::accumulate(t)      952     6.26%
Elliptic::accumulate(t)        605     3.98%
Auxiliary::accumulate(t)      3616    23.78%
EccOp::accumulate(t)             0     0.00%
DatabusRead::accumulate(t)       1     0.01%
PoseidonExt::accumulate(t)     112     0.74%
PoseidonInt::accumulate(t)     309     2.03%

@ledwards2225 ledwards2225 self-assigned this Jun 11, 2024
Copy link
Collaborator

@AztecBot AztecBot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'C++ Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.05.

Benchmark suite Current: c36266c Previous: ae97d60 Ratio
Goblin::merge(t) 215981207 ns/iter 202931586 ns/iter 1.06

This comment was automatically generated by workflow using github-action-benchmark.

CC: @ludamad @codygunton

@AztecBot
Copy link
Collaborator

AztecBot commented Jun 19, 2024

Benchmark results

Metrics with a significant change:

  • proof_construction_time_sha256_30_ms (16): 1,384 (-26%)
  • avm_simulation_time_ms (Token:transfer_public): 47.3 (+54%)
  • protocol_circuit_witness_generation_time_in_ms (private-kernel-reset-small): 2,451 (+24%)
Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Proof generation

Each column represents the number of threads used in proof generation.

Metric 1 threads 4 threads 16 threads 32 threads 64 threads
proof_construction_time_sha256_30_ms 11,358 (-1%) 3,056 (-2%) ⚠️ 1,384 (-26%) 1,528 (-5%) 1,595 (+4%)
proof_construction_time_sha256_100_ms 44,607 (-2%) 12,031 (-1%) 5,649 (-1%) 5,526 (-1%) 5,482 (-1%)
proof_construction_time_poseidon_hash_ms 78.0 34.0 34.0 58.0 (+2%) 88.0 (+1%)
proof_construction_time_poseidon_hash_30_ms 1,518 (-1%) 418 (-1%) 202 222 (-2%) 266
proof_construction_time_poseidon_hash_100_ms 5,729 (-1%) 1,570 (-1%) 725 793 (+4%) 791 (-2%)

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric 4 txs 8 txs 16 txs
l1_rollup_calldata_size_in_bytes 1,412 1,412 1,412
l1_rollup_calldata_gas 9,476 9,462 9,476
l1_rollup_execution_gas 610,297 610,283 610,297
l2_block_processing_time_in_ms 742 (-1%) 1,397 2,672 (-1%)
l2_block_building_time_in_ms 25,499 (+1%) 51,278 (+1%) 100,376 (+1%)
l2_block_rollup_simulation_time_in_ms 25,404 (+1%) 50,985 (+1%) 100,022 (+1%)
l2_block_public_tx_process_time_in_ms 21,835 (+1%) 47,219 (+1%) 96,274 (+1%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric 3 blocks 5 blocks
node_history_sync_time_in_ms 6,936 (+1%) 9,738
node_database_size_in_bytes 12,173,392 16,068,688
pxe_database_size_in_bytes 16,254 26,813

Circuits stats

Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit simulation_time_in_ms witness_generation_time_in_ms proving_time_in_ms input_size_in_bytes output_size_in_bytes proof_size_in_bytes num_public_inputs size_in_gates
private-kernel-init 131 (+2%) 461 (-3%) 13,364 (+3%) 20,634 67,190 92,352 2,819 524,288
private-kernel-inner 392 980 (+4%) 52,514 (+4%) 94,902 67,190 92,352 2,819 2,097,152
private-kernel-tail 372 (+1%) 1,791 (-2%) 52,525 99,121 71,733 14,912 399 2,097,152
base-parity 6.17 (-1%) 1,878 (-2%) 2,749 (-1%) 128 64.0 2,208 2.00 131,072
root-parity 48.8 63.0 (-2%) 43,473 (+9%) 27,100 64.0 2,720 18.0 2,097,152
base-rollup 7,903 (+1%) 4,378 (+1%) 85,309 170,330 756 3,648 47.0 4,194,304
root-rollup 110 77.8 (-3%) 23,449 (+6%) 25,309 620 3,456 41.0 1,048,576
public-kernel-setup 715 (-1%) 3,167 (-3%) 45,730 116,905 93,334 125,344 3,850 2,097,152
public-kernel-app-logic 616 (+1%) 4,028 (-6%) 48,809 (+3%) 116,905 93,334 125,344 3,850 2,097,152
public-kernel-tail 1,410 31,769 (-10%) 188,965 (-4%) 511,910 10,014 14,912 399 8,388,608
private-kernel-reset-small 596 (+1%) ⚠️ 2,451 (+24%) 46,790 (-3%) 123,313 67,190 92,352 2,819 2,097,152
public-kernel-teardown 616 (-2%) 4,059 (-3%) 47,356 (-1%) 116,905 93,334 125,344 3,850 2,097,152
merge-rollup 29.0 (+1%) N/A N/A 16,542 756 N/A N/A N/A
private-kernel-tail-to-public N/A 6,977 (-2%) 101,703 (+1%) N/A N/A 125,344 3,850 4,194,304

Stats on running time collected for app circuits

Function input_size_in_bytes output_size_in_bytes witness_generation_time_in_ms proof_size_in_bytes proving_time_in_ms size_in_gates num_public_inputs
ContractClassRegisterer:register 1,344 9,944 400 N/A N/A N/A N/A
ContractInstanceDeployer:deploy 1,408 9,944 39.6 (-1%) N/A N/A N/A N/A
MultiCallEntrypoint:entrypoint 1,920 9,944 1,767 (-1%) N/A N/A N/A N/A
GasToken:deploy 1,376 9,944 944 (-2%) N/A N/A N/A N/A
SchnorrAccount:constructor 1,312 9,944 1,419 (-1%) N/A N/A N/A N/A
SchnorrAccount:entrypoint 2,304 9,944 2,824 16,768 57,312 (+2%) 2,097,152 457
Token:privately_mint_private_note 1,280 9,944 1,646 (-2%) N/A N/A N/A N/A
FPC:fee_entrypoint_public 1,344 9,944 347 (-3%) 16,768 11,186 (-3%) 524,288 457
Token:transfer 1,312 9,944 4,396 (-1%) 16,768 45,841 (-7%) 2,097,152 457
AuthRegistry:set_authorized (avm) 21,043 N/A N/A 87,200 1,337 (-3%) N/A N/A
FPC:prepare_fee (avm) 28,841 N/A N/A 88,032 6,095 (+1%) N/A N/A
Token:transfer_public (avm) 44,971 N/A N/A 87,865 4,874 (+2%) N/A N/A
AuthRegistry:consume (avm) 34,973 N/A N/A 87,616 3,220 (+7%) N/A N/A
FPC:pay_refund (avm) 33,573 N/A N/A 88,448 11,244 (+2%) N/A N/A
Benchmarking:create_note 1,344 9,944 1,398 (-1%) N/A N/A N/A N/A
SchnorrAccount:verify_private_authwit 1,280 9,944 72.8 (-1%) N/A N/A N/A N/A
Token:unshield 1,376 9,944 3,571 N/A N/A N/A N/A
FPC:fee_entrypoint_private 1,376 9,944 4,498 (-1%) N/A N/A N/A N/A

AVM Simulation

Time to simulate various public functions in the AVM.

Function time_ms bytecode_size_in_bytes
GasToken:_increase_public_balance 66.9 (-4%) 13,873
GasToken:set_portal 16.6 (+3%) 3,495
Token:constructor 92.2 (-1%) 24,207
FPC:constructor 61.9 (+1%) 13,893
GasToken:mint_public 51.9 (-1%) 10,241
Token:mint_public 593 (-3%) 19,216
Token:assert_minter_and_mint 59.6 (-21%) 13,034
AuthRegistry:set_authorized 32.7 (+3%) 7,869
FPC:prepare_fee 140 (-22%) 15,187
Token:transfer_public ⚠️ 47.3 (+54%) 31,425
FPC:pay_refund 143 (+13%) 20,080
Benchmarking:increment_balance 2,695 (+1%) 15,465
Token:_increase_public_balance 55.7 (-8%) 15,089
FPC:pay_refund_with_shielded_rebate 134 (-15%) 21,167

Public DB Access

Time to access various public DBs.

Function time_ms
get-nullifier-index 0.177 (-2%)

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric 1 leaves 16 leaves 64 leaves 128 leaves 256 leaves 512 leaves 1024 leaves
batch_insert_into_append_only_tree_16_depth_ms 10.3 16.5 (-1%) N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_count 16.8 31.7 N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_ms 0.594 0.509 N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_32_depth_ms N/A N/A 47.8 (-1%) 75.6 130 (-1%) 244 465 (-1%)
batch_insert_into_append_only_tree_32_depth_hash_count N/A N/A 95.9 159 287 543 1,055
batch_insert_into_append_only_tree_32_depth_hash_ms N/A N/A 0.488 (-1%) 0.464 0.447 (-1%) 0.442 0.435 (-1%)
batch_insert_into_indexed_tree_20_depth_ms N/A N/A 58.9 (-1%) 111 181 (-1%) 352 (+1%) 690 (-1%)
batch_insert_into_indexed_tree_20_depth_hash_count N/A N/A 109 207 355 691 1,363
batch_insert_into_indexed_tree_20_depth_hash_ms N/A N/A 0.499 (-1%) 0.498 0.478 (-1%) 0.477 (+1%) 0.474
batch_insert_into_indexed_tree_40_depth_ms N/A N/A 72.1 N/A N/A N/A N/A
batch_insert_into_indexed_tree_40_depth_hash_count N/A N/A 133 N/A N/A N/A N/A
batch_insert_into_indexed_tree_40_depth_hash_ms N/A N/A 0.514 N/A N/A N/A N/A

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric 0 registered classes 1 registered classes
tx_size_in_bytes 85,672 670,983

Transaction size based on fee payment method

| Metric | |
| - | |

@ledwards2225 ledwards2225 marked this pull request as ready for review June 21, 2024 20:32
@maramihali maramihali self-requested a review June 24, 2024 13:35
* @brief Test various failure modes for the lookup relation via bad input polynomials
*
*/
TEST_F(UltraHonkComposerTests, LookupFailure)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not related to this PR, but since we dont have composers anymore maybe these should be called UltraHonk tests

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also really nice and comprehensive test :)

Copy link
Contributor

@maramihali maramihali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks really good, small requests for more documentation/clarifications here and there.

{
TestFixture::test_sorted_list_accumulator_construction();
}
};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are no tests here anymore so maybe we can remove this test file since incrementally functionality was removed out of the prover instance

@@ -213,7 +213,7 @@ struct MultiTable {
// std::array<bb::fr, 2> value{ bb::fr(0), bb::fr(0) };
// bool operator<(const KeyEntry& other) const { return key < other.key; }

// std::array<bb::fr, 3> to_sorted_list_components(const bool use_two_keys) const
// std::array<bb::fr, 3> to_table_components(const bool use_two_keys) const
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we maybe add an issue as to why all this stuff is commented out and whether we should get rid of it or fix it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this was something Adam was working on, not sure. I'll ping him on it

@ledwards2225 ledwards2225 merged commit 6f1212f into master Jun 25, 2024
91 checks passed
@ledwards2225 ledwards2225 deleted the lde/log_deriv_lookups branch June 25, 2024 15:41
sirasistant pushed a commit that referenced this pull request Jun 26, 2024
🤖 I have created a release *beep* *boop*
---


<details><summary>aztec-package: 0.44.0</summary>

##
[0.44.0](aztec-package-v0.43.0...aztec-package-v0.44.0)
(2024-06-26)


### Features

* Add OpenTelemetry to node
([#7102](#7102))
([6bf2b72](6bf2b72))
* Devnet deployments
([#7024](#7024))
([fa70876](fa70876))
* Track spans
([#7129](#7129))
([924c3f8](924c3f8))
</details>

<details><summary>barretenberg.js: 0.44.0</summary>

##
[0.44.0](barretenberg.js-v0.43.0...barretenberg.js-v0.44.0)
(2024-06-26)


### Bug Fixes

* False decryption fix
([#7066](#7066))
([48d9df4](48d9df4))
</details>

<details><summary>aztec-packages: 0.44.0</summary>

##
[0.44.0](aztec-packages-v0.43.0...aztec-packages-v0.44.0)
(2024-06-26)


### ⚠ BREAKING CHANGES

* make note_getter return BoundedVec instead of an Option array
([#7050](#7050))
* TXE
([#6985](#6985))

### Features

* Add macro impls for events
([#7081](#7081))
([c13dd9f](c13dd9f))
* Add OpenTelemetry to node
([#7102](#7102))
([6bf2b72](6bf2b72))
* Added prove_output_all flow for honk
([#6869](#6869))
([7bd7c66](7bd7c66))
* **avm:** Add ECC ops to avm_proving_test
([#7058](#7058))
([7f62a90](7f62a90))
* **avm:** Cpp msm changes
([#7056](#7056))
([f9c8f20](f9c8f20))
* **avm:** Include bb-pilcom in monorepo
([#7098](#7098))
([0442158](0442158))
* Constrain event encryption and unify note and event emit api
([#7171](#7171))
([5c3772f](5c3772f)),
closes
[#7160](#7160)
* Conventional lookups using log-deriv
([#7020](#7020))
([6f1212f](6f1212f))
* Devnet deployments
([#7024](#7024))
([fa70876](fa70876))
* Do not discard logs on revert since the kernel has pruned revertible
logs.
([#7076](#7076))
([366fb21](366fb21)),
closes
[#4712](#4712)
* **docs:** Publish PDF of protocol specs + remove links to pages in
item lists in protocol specs
([#6684](#6684))
([367e3cf](367e3cf))
* Enable merge recursive verifier in Goblin recursive verifier
([#7182](#7182))
([9b4f56c](9b4f56c))
* Flamegraph helper script
([#7077](#7077))
([8630c8f](8630c8f))
* Full test skips public simulation
([#7186](#7186))
([4c1997f](4c1997f))
* Make note_getter return BoundedVec instead of an Option array
([#7050](#7050))
([f9ac0fc](f9ac0fc))
* **p2p:** More comprehensive peer management, dial retries, persistence
fix
([#6953](#6953))
([cdd1cbd](cdd1cbd))
* Private authwit with static call
([#7073](#7073))
([9c52d47](9c52d47))
* Several updates in SMT verification module
([#7105](#7105))
([41b21f1](41b21f1))
* Shplonk revival in ECCVM
([#7164](#7164))
([34eb5a0](34eb5a0))
* Throwing errors in `BufferReader` when out of bounds
([#7149](#7149))
([bf4a986](bf4a986))
* Track spans
([#7129](#7129))
([924c3f8](924c3f8))
* TXE
([#6985](#6985))
([109624f](109624f))
* TXE 2: Electric boogaloo
([#7154](#7154))
([bb38246](bb38246))


### Bug Fixes

* **avm:** Fix unencryptedlog c++ deser
([#7194](#7194))
([89a99af](89a99af))
* **avm:** Re-enable ext call test
([#7147](#7147))
([33ccf1b](33ccf1b))
* **avm:** Reenable tag error sload
([#7153](#7153))
([fd92d46](fd92d46))
* **avm:** Update codegen
([#7178](#7178))
([1d29708](1d29708))
* Bug fixing bench prover test
([#7135](#7135))
([13678be](13678be)),
closes
[#7080](#7080)
* **ci:** Don't run npm_deploy l1-contracts
([#7187](#7187))
([80d26d8](80d26d8))
* **ci:** Move osxcross from build image
([#7151](#7151))
([7746363](7746363))
* Enable log filtering with the DEBUG variable
([#7150](#7150))
([33798b6](33798b6))
* Export event selector and replace function selector with event
selector where appropriate
([#7095](#7095))
([fcc15fa](fcc15fa)),
closes
[#7089](#7089)
* False decryption fix
([#7066](#7066))
([48d9df4](48d9df4))
* Fix bug for a unit test in full proving mode repated to MSM
([#7104](#7104))
([e37809b](e37809b))


### Miscellaneous

* `destroy_note(...)` optimization
([#7103](#7103))
([0770011](0770011))
* Add avm team as codeowners to more repo files
([#7196](#7196))
([9be0ad6](9be0ad6))
* **avm:** Remove avm prefix from pil and executor
([#7099](#7099))
([b502fcd](b502fcd))
* **avm:** Renamings and comments
([#7128](#7128))
([ed2f98e](ed2f98e))
* **avm:** Separate some fixed tables
([#7163](#7163))
([1d4a9a2](1d4a9a2))
* **ci:** Add new e2e base target
([#7179](#7179))
([26fc599](26fc599))
* Create workflow for full AVM tests
([#7051](#7051))
([a0b9c4b](a0b9c4b)),
closes
[#6643](#6643)
* **docs:** Fix migration notes
([#7195](#7195))
([88efda0](88efda0))
* **docs:** Moving tutorials and quick starts around, spinning off
codespaces page
([#6777](#6777))
([1542fa6](1542fa6))
* Fix migration notes
([#7133](#7133))
([14917d3](14917d3))
* Fix noir-projects dockerfile for CircleCI
([#7093](#7093))
([52ce25d](52ce25d))
* Increase the timeout of the runner for full AVM workflow to 70 minutes
([#7183](#7183))
([9aabc32](9aabc32))
* Indirects and read/write slices
([#7082](#7082))
([d5e80ee](d5e80ee))
* Note hashes cleanup + optimization
([#7132](#7132))
([edd6d3f](edd6d3f))
* Note hashing gate optimizations
([#7130](#7130))
([81a2580](81a2580))
* **powdr:** Update to latest and add logging
([#7152](#7152))
([f500f2e](f500f2e))
* Reads the return data
([#6669](#6669))
([ef85542](ef85542))
* Refactor AVM simulator's side-effect tracing
([#7091](#7091))
([9495413](9495413))
* Remove stray files
([#7158](#7158))
([29398de](29398de))
* Remove unneeded public input folding
([#7094](#7094))
([c30dc38](c30dc38))
* Replace relative paths to noir-protocol-circuits
([f7e4392](f7e4392))
* Replace relative paths to noir-protocol-circuits
([886f7b1](886f7b1))
* Replace relative paths to noir-protocol-circuits
([b1081f8](b1081f8))
* Replace relative paths to noir-protocol-circuits
([c0989eb](c0989eb))
* Replace relative paths to noir-protocol-circuits
([525bbe7](525bbe7))
* Replace relative paths to noir-protocol-circuits
([67bcd82](67bcd82))
* Take the PCS out of Zeromorph and refactor tests
([#7078](#7078))
([e192678](e192678))
* Track avm proving time
([#7084](#7084))
([59df722](59df722))
* Ultra flavor cleanup
([#7070](#7070))
([77761c6](77761c6))
</details>

<details><summary>barretenberg: 0.44.0</summary>

##
[0.44.0](barretenberg-v0.43.0...barretenberg-v0.44.0)
(2024-06-26)


### Features

* Added prove_output_all flow for honk
([#6869](#6869))
([7bd7c66](7bd7c66))
* **avm:** Add ECC ops to avm_proving_test
([#7058](#7058))
([7f62a90](7f62a90))
* **avm:** Cpp msm changes
([#7056](#7056))
([f9c8f20](f9c8f20))
* **avm:** Include bb-pilcom in monorepo
([#7098](#7098))
([0442158](0442158))
* Conventional lookups using log-deriv
([#7020](#7020))
([6f1212f](6f1212f))
* Enable merge recursive verifier in Goblin recursive verifier
([#7182](#7182))
([9b4f56c](9b4f56c))
* Several updates in SMT verification module
([#7105](#7105))
([41b21f1](41b21f1))
* Shplonk revival in ECCVM
([#7164](#7164))
([34eb5a0](34eb5a0))


### Bug Fixes

* **avm:** Fix unencryptedlog c++ deser
([#7194](#7194))
([89a99af](89a99af))
* **avm:** Re-enable ext call test
([#7147](#7147))
([33ccf1b](33ccf1b))
* **avm:** Reenable tag error sload
([#7153](#7153))
([fd92d46](fd92d46))
* **avm:** Update codegen
([#7178](#7178))
([1d29708](1d29708))
* Bug fixing bench prover test
([#7135](#7135))
([13678be](13678be)),
closes
[#7080](#7080)
* Fix bug for a unit test in full proving mode repated to MSM
([#7104](#7104))
([e37809b](e37809b))


### Miscellaneous

* **avm:** Remove avm prefix from pil and executor
([#7099](#7099))
([b502fcd](b502fcd))
* **avm:** Renamings and comments
([#7128](#7128))
([ed2f98e](ed2f98e))
* **avm:** Separate some fixed tables
([#7163](#7163))
([1d4a9a2](1d4a9a2))
* Create workflow for full AVM tests
([#7051](#7051))
([a0b9c4b](a0b9c4b)),
closes
[#6643](#6643)
* Indirects and read/write slices
([#7082](#7082))
([d5e80ee](d5e80ee))
* Reads the return data
([#6669](#6669))
([ef85542](ef85542))
* Remove unneeded public input folding
([#7094](#7094))
([c30dc38](c30dc38))
* Take the PCS out of Zeromorph and refactor tests
([#7078](#7078))
([e192678](e192678))
* Ultra flavor cleanup
([#7070](#7070))
([77761c6](77761c6))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
AztecBot added a commit to AztecProtocol/barretenberg that referenced this pull request Jun 27, 2024
🤖 I have created a release *beep* *boop*
---


<details><summary>aztec-package: 0.44.0</summary>

##
[0.44.0](AztecProtocol/aztec-packages@aztec-package-v0.43.0...aztec-package-v0.44.0)
(2024-06-26)


### Features

* Add OpenTelemetry to node
([#7102](AztecProtocol/aztec-packages#7102))
([6bf2b72](AztecProtocol/aztec-packages@6bf2b72))
* Devnet deployments
([#7024](AztecProtocol/aztec-packages#7024))
([fa70876](AztecProtocol/aztec-packages@fa70876))
* Track spans
([#7129](AztecProtocol/aztec-packages#7129))
([924c3f8](AztecProtocol/aztec-packages@924c3f8))
</details>

<details><summary>barretenberg.js: 0.44.0</summary>

##
[0.44.0](AztecProtocol/aztec-packages@barretenberg.js-v0.43.0...barretenberg.js-v0.44.0)
(2024-06-26)


### Bug Fixes

* False decryption fix
([#7066](AztecProtocol/aztec-packages#7066))
([48d9df4](AztecProtocol/aztec-packages@48d9df4))
</details>

<details><summary>aztec-packages: 0.44.0</summary>

##
[0.44.0](AztecProtocol/aztec-packages@aztec-packages-v0.43.0...aztec-packages-v0.44.0)
(2024-06-26)


### ⚠ BREAKING CHANGES

* make note_getter return BoundedVec instead of an Option array
([#7050](AztecProtocol/aztec-packages#7050))
* TXE
([#6985](AztecProtocol/aztec-packages#6985))

### Features

* Add macro impls for events
([#7081](AztecProtocol/aztec-packages#7081))
([c13dd9f](AztecProtocol/aztec-packages@c13dd9f))
* Add OpenTelemetry to node
([#7102](AztecProtocol/aztec-packages#7102))
([6bf2b72](AztecProtocol/aztec-packages@6bf2b72))
* Added prove_output_all flow for honk
([#6869](AztecProtocol/aztec-packages#6869))
([7bd7c66](AztecProtocol/aztec-packages@7bd7c66))
* **avm:** Add ECC ops to avm_proving_test
([#7058](AztecProtocol/aztec-packages#7058))
([7f62a90](AztecProtocol/aztec-packages@7f62a90))
* **avm:** Cpp msm changes
([#7056](AztecProtocol/aztec-packages#7056))
([f9c8f20](AztecProtocol/aztec-packages@f9c8f20))
* **avm:** Include bb-pilcom in monorepo
([#7098](AztecProtocol/aztec-packages#7098))
([0442158](AztecProtocol/aztec-packages@0442158))
* Constrain event encryption and unify note and event emit api
([#7171](AztecProtocol/aztec-packages#7171))
([5c3772f](AztecProtocol/aztec-packages@5c3772f)),
closes
[#7160](AztecProtocol/aztec-packages#7160)
* Conventional lookups using log-deriv
([#7020](AztecProtocol/aztec-packages#7020))
([6f1212f](AztecProtocol/aztec-packages@6f1212f))
* Devnet deployments
([#7024](AztecProtocol/aztec-packages#7024))
([fa70876](AztecProtocol/aztec-packages@fa70876))
* Do not discard logs on revert since the kernel has pruned revertible
logs.
([#7076](AztecProtocol/aztec-packages#7076))
([366fb21](AztecProtocol/aztec-packages@366fb21)),
closes
[#4712](AztecProtocol/aztec-packages#4712)
* **docs:** Publish PDF of protocol specs + remove links to pages in
item lists in protocol specs
([#6684](AztecProtocol/aztec-packages#6684))
([367e3cf](AztecProtocol/aztec-packages@367e3cf))
* Enable merge recursive verifier in Goblin recursive verifier
([#7182](AztecProtocol/aztec-packages#7182))
([9b4f56c](AztecProtocol/aztec-packages@9b4f56c))
* Flamegraph helper script
([#7077](AztecProtocol/aztec-packages#7077))
([8630c8f](AztecProtocol/aztec-packages@8630c8f))
* Full test skips public simulation
([#7186](AztecProtocol/aztec-packages#7186))
([4c1997f](AztecProtocol/aztec-packages@4c1997f))
* Make note_getter return BoundedVec instead of an Option array
([#7050](AztecProtocol/aztec-packages#7050))
([f9ac0fc](AztecProtocol/aztec-packages@f9ac0fc))
* **p2p:** More comprehensive peer management, dial retries, persistence
fix
([#6953](AztecProtocol/aztec-packages#6953))
([cdd1cbd](AztecProtocol/aztec-packages@cdd1cbd))
* Private authwit with static call
([#7073](AztecProtocol/aztec-packages#7073))
([9c52d47](AztecProtocol/aztec-packages@9c52d47))
* Several updates in SMT verification module
([#7105](AztecProtocol/aztec-packages#7105))
([41b21f1](AztecProtocol/aztec-packages@41b21f1))
* Shplonk revival in ECCVM
([#7164](AztecProtocol/aztec-packages#7164))
([34eb5a0](AztecProtocol/aztec-packages@34eb5a0))
* Throwing errors in `BufferReader` when out of bounds
([#7149](AztecProtocol/aztec-packages#7149))
([bf4a986](AztecProtocol/aztec-packages@bf4a986))
* Track spans
([#7129](AztecProtocol/aztec-packages#7129))
([924c3f8](AztecProtocol/aztec-packages@924c3f8))
* TXE
([#6985](AztecProtocol/aztec-packages#6985))
([109624f](AztecProtocol/aztec-packages@109624f))
* TXE 2: Electric boogaloo
([#7154](AztecProtocol/aztec-packages#7154))
([bb38246](AztecProtocol/aztec-packages@bb38246))


### Bug Fixes

* **avm:** Fix unencryptedlog c++ deser
([#7194](AztecProtocol/aztec-packages#7194))
([89a99af](AztecProtocol/aztec-packages@89a99af))
* **avm:** Re-enable ext call test
([#7147](AztecProtocol/aztec-packages#7147))
([33ccf1b](AztecProtocol/aztec-packages@33ccf1b))
* **avm:** Reenable tag error sload
([#7153](AztecProtocol/aztec-packages#7153))
([fd92d46](AztecProtocol/aztec-packages@fd92d46))
* **avm:** Update codegen
([#7178](AztecProtocol/aztec-packages#7178))
([1d29708](AztecProtocol/aztec-packages@1d29708))
* Bug fixing bench prover test
([#7135](AztecProtocol/aztec-packages#7135))
([13678be](AztecProtocol/aztec-packages@13678be)),
closes
[#7080](AztecProtocol/aztec-packages#7080)
* **ci:** Don't run npm_deploy l1-contracts
([#7187](AztecProtocol/aztec-packages#7187))
([80d26d8](AztecProtocol/aztec-packages@80d26d8))
* **ci:** Move osxcross from build image
([#7151](AztecProtocol/aztec-packages#7151))
([7746363](AztecProtocol/aztec-packages@7746363))
* Enable log filtering with the DEBUG variable
([#7150](AztecProtocol/aztec-packages#7150))
([33798b6](AztecProtocol/aztec-packages@33798b6))
* Export event selector and replace function selector with event
selector where appropriate
([#7095](AztecProtocol/aztec-packages#7095))
([fcc15fa](AztecProtocol/aztec-packages@fcc15fa)),
closes
[#7089](AztecProtocol/aztec-packages#7089)
* False decryption fix
([#7066](AztecProtocol/aztec-packages#7066))
([48d9df4](AztecProtocol/aztec-packages@48d9df4))
* Fix bug for a unit test in full proving mode repated to MSM
([#7104](AztecProtocol/aztec-packages#7104))
([e37809b](AztecProtocol/aztec-packages@e37809b))


### Miscellaneous

* `destroy_note(...)` optimization
([#7103](AztecProtocol/aztec-packages#7103))
([0770011](AztecProtocol/aztec-packages@0770011))
* Add avm team as codeowners to more repo files
([#7196](AztecProtocol/aztec-packages#7196))
([9be0ad6](AztecProtocol/aztec-packages@9be0ad6))
* **avm:** Remove avm prefix from pil and executor
([#7099](AztecProtocol/aztec-packages#7099))
([b502fcd](AztecProtocol/aztec-packages@b502fcd))
* **avm:** Renamings and comments
([#7128](AztecProtocol/aztec-packages#7128))
([ed2f98e](AztecProtocol/aztec-packages@ed2f98e))
* **avm:** Separate some fixed tables
([#7163](AztecProtocol/aztec-packages#7163))
([1d4a9a2](AztecProtocol/aztec-packages@1d4a9a2))
* **ci:** Add new e2e base target
([#7179](AztecProtocol/aztec-packages#7179))
([26fc599](AztecProtocol/aztec-packages@26fc599))
* Create workflow for full AVM tests
([#7051](AztecProtocol/aztec-packages#7051))
([a0b9c4b](AztecProtocol/aztec-packages@a0b9c4b)),
closes
[#6643](AztecProtocol/aztec-packages#6643)
* **docs:** Fix migration notes
([#7195](AztecProtocol/aztec-packages#7195))
([88efda0](AztecProtocol/aztec-packages@88efda0))
* **docs:** Moving tutorials and quick starts around, spinning off
codespaces page
([#6777](AztecProtocol/aztec-packages#6777))
([1542fa6](AztecProtocol/aztec-packages@1542fa6))
* Fix migration notes
([#7133](AztecProtocol/aztec-packages#7133))
([14917d3](AztecProtocol/aztec-packages@14917d3))
* Fix noir-projects dockerfile for CircleCI
([#7093](AztecProtocol/aztec-packages#7093))
([52ce25d](AztecProtocol/aztec-packages@52ce25d))
* Increase the timeout of the runner for full AVM workflow to 70 minutes
([#7183](AztecProtocol/aztec-packages#7183))
([9aabc32](AztecProtocol/aztec-packages@9aabc32))
* Indirects and read/write slices
([#7082](AztecProtocol/aztec-packages#7082))
([d5e80ee](AztecProtocol/aztec-packages@d5e80ee))
* Note hashes cleanup + optimization
([#7132](AztecProtocol/aztec-packages#7132))
([edd6d3f](AztecProtocol/aztec-packages@edd6d3f))
* Note hashing gate optimizations
([#7130](AztecProtocol/aztec-packages#7130))
([81a2580](AztecProtocol/aztec-packages@81a2580))
* **powdr:** Update to latest and add logging
([#7152](AztecProtocol/aztec-packages#7152))
([f500f2e](AztecProtocol/aztec-packages@f500f2e))
* Reads the return data
([#6669](AztecProtocol/aztec-packages#6669))
([ef85542](AztecProtocol/aztec-packages@ef85542))
* Refactor AVM simulator's side-effect tracing
([#7091](AztecProtocol/aztec-packages#7091))
([9495413](AztecProtocol/aztec-packages@9495413))
* Remove stray files
([#7158](AztecProtocol/aztec-packages#7158))
([29398de](AztecProtocol/aztec-packages@29398de))
* Remove unneeded public input folding
([#7094](AztecProtocol/aztec-packages#7094))
([c30dc38](AztecProtocol/aztec-packages@c30dc38))
* Replace relative paths to noir-protocol-circuits
([f7e4392](AztecProtocol/aztec-packages@f7e4392))
* Replace relative paths to noir-protocol-circuits
([886f7b1](AztecProtocol/aztec-packages@886f7b1))
* Replace relative paths to noir-protocol-circuits
([b1081f8](AztecProtocol/aztec-packages@b1081f8))
* Replace relative paths to noir-protocol-circuits
([c0989eb](AztecProtocol/aztec-packages@c0989eb))
* Replace relative paths to noir-protocol-circuits
([525bbe7](AztecProtocol/aztec-packages@525bbe7))
* Replace relative paths to noir-protocol-circuits
([67bcd82](AztecProtocol/aztec-packages@67bcd82))
* Take the PCS out of Zeromorph and refactor tests
([#7078](AztecProtocol/aztec-packages#7078))
([e192678](AztecProtocol/aztec-packages@e192678))
* Track avm proving time
([#7084](AztecProtocol/aztec-packages#7084))
([59df722](AztecProtocol/aztec-packages@59df722))
* Ultra flavor cleanup
([#7070](AztecProtocol/aztec-packages#7070))
([77761c6](AztecProtocol/aztec-packages@77761c6))
</details>

<details><summary>barretenberg: 0.44.0</summary>

##
[0.44.0](AztecProtocol/aztec-packages@barretenberg-v0.43.0...barretenberg-v0.44.0)
(2024-06-26)


### Features

* Added prove_output_all flow for honk
([#6869](AztecProtocol/aztec-packages#6869))
([7bd7c66](AztecProtocol/aztec-packages@7bd7c66))
* **avm:** Add ECC ops to avm_proving_test
([#7058](AztecProtocol/aztec-packages#7058))
([7f62a90](AztecProtocol/aztec-packages@7f62a90))
* **avm:** Cpp msm changes
([#7056](AztecProtocol/aztec-packages#7056))
([f9c8f20](AztecProtocol/aztec-packages@f9c8f20))
* **avm:** Include bb-pilcom in monorepo
([#7098](AztecProtocol/aztec-packages#7098))
([0442158](AztecProtocol/aztec-packages@0442158))
* Conventional lookups using log-deriv
([#7020](AztecProtocol/aztec-packages#7020))
([6f1212f](AztecProtocol/aztec-packages@6f1212f))
* Enable merge recursive verifier in Goblin recursive verifier
([#7182](AztecProtocol/aztec-packages#7182))
([9b4f56c](AztecProtocol/aztec-packages@9b4f56c))
* Several updates in SMT verification module
([#7105](AztecProtocol/aztec-packages#7105))
([41b21f1](AztecProtocol/aztec-packages@41b21f1))
* Shplonk revival in ECCVM
([#7164](AztecProtocol/aztec-packages#7164))
([34eb5a0](AztecProtocol/aztec-packages@34eb5a0))


### Bug Fixes

* **avm:** Fix unencryptedlog c++ deser
([#7194](AztecProtocol/aztec-packages#7194))
([89a99af](AztecProtocol/aztec-packages@89a99af))
* **avm:** Re-enable ext call test
([#7147](AztecProtocol/aztec-packages#7147))
([33ccf1b](AztecProtocol/aztec-packages@33ccf1b))
* **avm:** Reenable tag error sload
([#7153](AztecProtocol/aztec-packages#7153))
([fd92d46](AztecProtocol/aztec-packages@fd92d46))
* **avm:** Update codegen
([#7178](AztecProtocol/aztec-packages#7178))
([1d29708](AztecProtocol/aztec-packages@1d29708))
* Bug fixing bench prover test
([#7135](AztecProtocol/aztec-packages#7135))
([13678be](AztecProtocol/aztec-packages@13678be)),
closes
[#7080](AztecProtocol/aztec-packages#7080)
* Fix bug for a unit test in full proving mode repated to MSM
([#7104](AztecProtocol/aztec-packages#7104))
([e37809b](AztecProtocol/aztec-packages@e37809b))


### Miscellaneous

* **avm:** Remove avm prefix from pil and executor
([#7099](AztecProtocol/aztec-packages#7099))
([b502fcd](AztecProtocol/aztec-packages@b502fcd))
* **avm:** Renamings and comments
([#7128](AztecProtocol/aztec-packages#7128))
([ed2f98e](AztecProtocol/aztec-packages@ed2f98e))
* **avm:** Separate some fixed tables
([#7163](AztecProtocol/aztec-packages#7163))
([1d4a9a2](AztecProtocol/aztec-packages@1d4a9a2))
* Create workflow for full AVM tests
([#7051](AztecProtocol/aztec-packages#7051))
([a0b9c4b](AztecProtocol/aztec-packages@a0b9c4b)),
closes
[#6643](AztecProtocol/aztec-packages#6643)
* Indirects and read/write slices
([#7082](AztecProtocol/aztec-packages#7082))
([d5e80ee](AztecProtocol/aztec-packages@d5e80ee))
* Reads the return data
([#6669](AztecProtocol/aztec-packages#6669))
([ef85542](AztecProtocol/aztec-packages@ef85542))
* Remove unneeded public input folding
([#7094](AztecProtocol/aztec-packages#7094))
([c30dc38](AztecProtocol/aztec-packages@c30dc38))
* Take the PCS out of Zeromorph and refactor tests
([#7078](AztecProtocol/aztec-packages#7078))
([e192678](AztecProtocol/aztec-packages@e192678))
* Ultra flavor cleanup
([#7070](AztecProtocol/aztec-packages#7070))
([77761c6](AztecProtocol/aztec-packages@77761c6))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants